SitePoint Sponsor

User Tag List

Results 1 to 9 of 9
  1. #1
    SitePoint Member
    Join Date
    Feb 2012
    Posts
    13
    Mentioned
    0 Post(s)
    Tagged
    0 Thread(s)

    What is "code review" ?

    Hello

    I have a site being developed, in aspx / dot net, there a few developers, the lead programmer insists on "code reviews" and they take a long time. What are they?
    What is "code review"?

    If other developers test along the way and debug their code, and it works fine on one anothers machines and fulfills the functionality required then what is the role of "code review"?

    Thank you in advance for any help

  2. #2
    Barefoot on the Moon! silver trophy
    Force Flow's Avatar
    Join Date
    Jul 2003
    Location
    Northeastern USA
    Posts
    4,516
    Mentioned
    51 Post(s)
    Tagged
    1 Thread(s)
    This pretty much sums it up: http://en.wikipedia.org/wiki/Code_review
    Visit The Blog | Follow On Twitter
    301tool 1.1.5 - URL redirector & shortener (PHP/MySQL)
    Can be hosted on and utilize your own domain

  3. #3
    SitePoint Zealot behati's Avatar
    Join Date
    Feb 2012
    Location
    Copenhagen, Denmark
    Posts
    152
    Mentioned
    1 Post(s)
    Tagged
    0 Thread(s)
    It's quite literally a review of the code that has been written. Usually in Software Development projects the Lead or Principal Developer will want to conduct code reviews, usually using things like Version Control Pull Requests. The actual process of reviewing code is of course down to the whoever is the reviewer, maybe they are looking for something specific, or they have a general set of rules and standards that the code needs to live up to. If it's taking a long time then the process is probably not very good, or the chunks up for review are simply too large - I find that the best code review is on small additions / patches of recent work that is fresh in the memory of the reviewer (who is likely to have been part in the system architecture planning).

    As for just accepting that the code runs on the developers machine, the reviewer may be looking at solution quality, e.g. just because it works does not mean that the solutions is good and optimal. Furthermore the reviewer may have experience regarding things that may or may not work on different systems and setups and therefore the fact that it works on the developers machine is not enough.

    In short, the process of Code Review is an individual process that is important, but if it's taking so long that it significantly slows down development then the process may be flawed or the reviewer does not have the adequate experience to quickly spot whether or not an implementation is "good enough" to pass the review.

  4. #4
    SitePoint Member
    Join Date
    Nov 2011
    Location
    Indianapolis, IN
    Posts
    1
    Mentioned
    0 Post(s)
    Tagged
    0 Thread(s)
    Code review is the best way to catch bugs before code goes into production. It also helps developers share knowledge between each other, unify coding styles, and

    There are bugs automated tests won't be able to find. Additionally, regular code review can help developers think of better ways to solve problems.

    Code review can take a while, sure, but the payoff is absolutely worth it.

    <snip/>
    Last edited by Mittineague; Jun 14, 2013 at 12:50. Reason: please read the FAQ

  5. #5
    Programming Since 1978 silver trophybronze trophy felgall's Avatar
    Join Date
    Sep 2005
    Location
    Sydney, NSW, Australia
    Posts
    16,597
    Mentioned
    24 Post(s)
    Tagged
    1 Thread(s)
    Code review also ensures that everyone is following the same in house standards with the code that they write. This will cover lots of things that do not make any difference to whether the code works or not such as indentation. It basically ensures that everyone's code is written the same way so that everyone can maintain all the code as if they were the sole programmer responsible for writing it.
    Stephen J Chapman

    javascriptexample.net, Book Reviews, follow me on Twitter
    HTML Help, CSS Help, JavaScript Help, PHP/mySQL Help, blog
    <input name="html5" type="text" required pattern="^$">

  6. #6
    SitePoint Author silver trophybronze trophy
    wwb_99's Avatar
    Join Date
    May 2003
    Location
    Washington, DC
    Posts
    10,576
    Mentioned
    4 Post(s)
    Tagged
    0 Thread(s)
    On top of what has been mentioned code reviews are wonderful opportunity for you to learn from the senior developers -- there is a lot more than meeting the functional requirements to software development.

  7. #7
    SitePoint Wizard
    Join Date
    Apr 2007
    Posts
    1,381
    Mentioned
    2 Post(s)
    Tagged
    0 Thread(s)
    I'm currently in a dev team where Code Review is essential. Previous jobs, I did code review during meetings or other type of face-to-face meetings. Now, there are plenty of tools to perform code review where a developer can do it anytime. The cons is that un-reviewed code must be checked in. After that other developers can start looking at your changes. If it's to a point that it needs a re-write up then all you need to do is rollback the check-ins. I really do like code review since other catch my stupid mistakes but I don't get why we don't code review our techlead/architect codes..just seems a bit unfair.

  8. #8
    SitePoint Author silver trophybronze trophy
    wwb_99's Avatar
    Join Date
    May 2003
    Location
    Washington, DC
    Posts
    10,576
    Mentioned
    4 Post(s)
    Tagged
    0 Thread(s)
    In a perfect world the tech leads / architects are reviewing each other.

  9. #9
    Non-Member
    Join Date
    Jun 2013
    Posts
    3
    Mentioned
    0 Post(s)
    Tagged
    0 Thread(s)
    It is a phrase in the software development process in which the authors of code and perhaps quality assurance mentors get together to review code. Code review is systematic examination of computer source code.

    Code review fall into three main categories:
    (1) pair programming,
    (2) formal code review and
    (3) lightweight code review..


Bookmarks

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •